Fix overwriting superadmin password on container start (#2494)

* Fix overwriting superadmin password

* style

* Reorder tests such that default PW stays active

* Actually fetch the user to compare password

* Assert logout after init-data to fix other tests

openslides_backend/http/application.py

@@ -71,6 +71,7 @@ def create_initial_data(self) -> None:
                 )
             except ActionException as e:
                 self.logger.error(f"Initial data creation failed: {e}")
+                return
 
             # in prod mode, set superadmin password
             if not self.env.is_dev_mode():

tests/system/action/test_create_initial_data.py

@@ -34,6 +34,29 @@ def test_initial_data_error(self, mock: MagicMock) -> None:
         self.logger.info.assert_any_call("Creating initial data...")
         self.logger.error.assert_called_with("Initial data creation failed: test")
 
+    def test_initial_data_prod_mode_changed_superadmin_password(self) -> None:
+        with tempfile.NamedTemporaryFile(delete=False) as fp:
+            fp.write(b"password123")
+        self.env.vars["OPENSLIDES_DEVELOPMENT"] = "false"
+        self.env.vars["SUPERADMIN_PASSWORD_FILE"] = fp.name
+        self.app.create_initial_data()
+        self.logger.info.assert_any_call("Creating initial data...")
+        self.logger.error.assert_not_called()
+        self.assert_model_exists("organization/1", {"name": "[Your organization]"})
+        user = self.assert_model_exists("user/1", {"username": "superadmin"})
+        assert self.auth.is_equal("password123", user["password"])
+        self.request(
+            "user.set_password",
+            {
+                "id": 1,
+                "password": "password456",
+            },
+        )
+        self.app.create_initial_data()
+        user = self.assert_model_exists("user/1", {"username": "superadmin"})
+        assert self.auth.is_equal("password456", user["password"])
+        self.assert_logged_out()
+
     def test_initial_data_prod_mode(self) -> None:
         with tempfile.NamedTemporaryFile(delete=False) as fp:
             fp.write(b"password123")