tests: add (xfail) ETCS braking curve integration test #10294
+88
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:core
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10294 +/- ##
==========================================
- Coverage 81.58% 81.56% -0.02%
==========================================
Files 1062 1062
Lines 104970 105009 +39
Branches 722 722
==========================================
+ Hits 85636 85655 +19
- Misses 19293 19313 +20
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Base automatically changed from
peb/editoast/add_etcs_brake_params_to_rs_model
to
dev
January 9, 2025 09:49
shenriotpro
reviewed
Jan 9, 2025
| @@ -37,6 +37,13 @@ def small_infra() -> Iterator[Infra]: | |||
| requests.delete(EDITOAST_URL + f"infra/{infra_id}/") | |||
|
|
|||
|
|
|||
| @pytest.fixture(scope="session") | |||
| def etcs_infra() -> Iterator[Infra]: | |||
| @@ -115,9 +132,9 @@ class TestRollingStock: | |||
| TestRollingStock.__test__ = False | |||
|
|
|||
|
|
|||
| def create_fast_rolling_stocks(test_rolling_stocks: Optional[List[TestRollingStock]] = None): | |||
| def create_rolling_stock(rolling_stock_json_path: Path, test_rolling_stocks: Optional[List[TestRollingStock]] = None): | |||
There was a problem hiding this comment.
nit: can we add a return type?
| @@ -187,6 +213,7 @@ def west_to_south_east_simulation( | |||
| {"offset": 837034, "track": "TA2", "id": "a"}, | |||
| {"offset": 4386000, "track": "TH1", "id": "b"}, | |||
| ], | |||
| "schedule": [{"at": "b", "stop_for": "PT0S"}], | |||
There was a problem hiding this comment.
Is there a description of the new infra/rs somewhere?
| assert get_current_or_next_speed_at(simulation_final_output, final_stop_const_brake_start_offset + 1) < 39.444 | ||
|
|
||
|
|
||
| def get_current_or_next_speed_at(simulation_final_output: Dict[str, Any], position: int) -> int: |
There was a problem hiding this comment.
nit: if we don't want to export it, let's call it _get_current_or_next_speed_at
* Added the final stop to get a final braking curve. * ETCS is not available, so unplugged it to avoid crash (fallback to const gamma). * So tests added are wrong and must break/be modified when plugging ETCS. Signed-off-by: Pierre-Etienne Bougué <[email protected]>
bougue-pe
force-pushed
the
peb/tests/add_etcs_integration_tests
branch
from
3e87ad4 to
53afcc1
Compare
bougue-pe
requested review from
a team and
bloussou
and removed request for
a team and
bloussou
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged once #10147
Fixes part of #9706