Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: group osrd-ui dependabot upgrades #10225

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

emersion
Copy link
Member

@emersion emersion commented Jan 3, 2025

osrd-ui has an unusual versioning scheme: it uses 0.0.x and all releases may contain breaking changes.

osrd-ui has an unusual versioning scheme: it uses 0.0.x and all
releases may contain breaking changes.

Signed-off-by: Simon Ser <[email protected]>
@emersion emersion requested a review from SharglutDev January 3, 2025 08:56
@emersion emersion requested a review from a team as a code owner January 3, 2025 08:56
@github-actions github-actions bot added the area:ci Work on Continous Integration Pipeline Service label Jan 3, 2025
@SharglutDev
Copy link
Contributor

This still allows dependabot to bump osrd-ui ? I'm afraid some "ghost" changes which doesn't break the CI - like one in v0.0.58 - might be forgotten. Or should we still allow it and be more rigorous for these kind of changes (like always creating a separated issue from the bump) ?

@emersion
Copy link
Member Author

emersion commented Jan 3, 2025

dependabot will create a separate PR with all osrd-ui upgrades. Then it's up to the reviewer to check the changelog and make sure the breaking changes are all accounted for. I don't think there's anything really osrd-ui-specific here, any dependency upgrade can pass CI and still break stuff :P

@SharglutDev
Copy link
Contributor

It's kind of an edge case anyway as most of the time we bump osrd-ui ourself just after a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Work on Continous Integration Pipeline Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants