editoast: endpoints to retrieve stdcm payloads #10212
Conversation
Signed-off-by: hamz2a <[email protected]>
github-actions
bot
added
area:front
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10212 +/- ##
==========================================
+ Coverage 81.46% 81.52% +0.05%
==========================================
Files 1058 1058
Lines 104318 104380 +62
Branches 724 720 -4
==========================================
+ Hits 84981 85094 +113
+ Misses 19295 19244 -51
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: hamz2a <[email protected]>
hamz2a
force-pushed
the
hai/editoast-endpoint-to-retrieve-stdcm-payloads
branch
from
d728975 to
a539bb6
Compare
| arrival_time_tolerance_after: number; | ||
| /** The train may arrive up to this duration before the expected arrival time */ | ||
| arrival_time_tolerance_before: number; | ||
| export type Response = |
There was a problem hiding this comment.
Looks like the same type as PostTimetableByIdStdcmApiResponse, do we need another one ? Or we could reuse this in it with : export type PostTimetableByIdStdcmApiResponse = Response.
Also Request and Response are too vague imo, we could do StdcmRequest and StdcmResponse ?
| train_ids: number[]; | ||
| /** List of work schedule ids involved in the conflict */ | ||
| work_schedule_ids: number[]; | ||
| export type Request = { |
There was a problem hiding this comment.
Same type as PostTimetableByIdStdcmApiArg['body'], we could reuse it inside ?
Part of #9724
Warning
We need to wait for this PR to be merged before merging that one.