front: move grid margins props from commonConf to stdcmConf reducer #10203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #10203 +/- ##
==========================================
- Coverage 81.44% 81.41% -0.03%
==========================================
Files 1058 1058
Lines 104243 104248 +5
Branches 724 724
==========================================
- Hits 84900 84875 -25
- Misses 19301 19331 +30
Partials 42 42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clarani
force-pushed
the
cni/move-grid-margin-in-stdcm-reducer
branch
from
7e9b091 to
e613c85
Compare
SharglutDev
reviewed
Jan 2, 2025
front/src/reducers/osrdconf/stdcmConf/stdcmConfReducers.spec.ts
Outdated
Show resolved
Hide resolved
|
@SharglutDev I fixed some of your comments related to cleaning AllowanceValue type in this PR, since it was a bit out of scope 👍 |
clarani
force-pushed
the
cni/move-grid-margin-in-stdcm-reducer
branch
from
4cc018e to
4b0f9e3
Compare
Also rename stdcmStandardAllowance and group all the margins values together in the store Signed-off-by: Clara Ni <[email protected]>
…on resetMargins Signed-off-by: Clara Ni <[email protected]>
clarani
force-pushed
the
cni/move-grid-margin-in-stdcm-reducer
branch
from
4b0f9e3 to
855a51f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ To merge after #10202