This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Image update #4
Open
Image update #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working to ensure there will be documented/working packer support for ONE.
Turns out someone (by name of Wiliam Petit?) had made apparently made a working solution but told noone about it.
See, there's a packer post-processor for OpenNebula:
Cadoles/packer-opennebula
In the go build deps I also found reference to a fork of goca including the branch
image-updatein this PR.From what I can see it wasn't ever made a PR, so even with my limitations of not knowing anything about go, or goca and not being the author: here you go.
The PR basically seems to just implement permission management (chown/chmod) on images. I've not spotted any bad style or questionable behaviour.
Please could you give this snippet a review for sense-making and merge-ability?
I really want to get this to back to life before the code rot is unsolvable.
Personally I can see a long chain of features attached to this (combining working function of packer, terraform, vagrant... is more than just the sum of the parts.)