Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce modern UI #262

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Introduce modern UI #262

wants to merge 2 commits into from

Conversation

williambj1
Copy link
Collaborator

@williambj1 williambj1 commented Aug 3, 2024 •
edited
Loading

Feedback on UI glitches across different macOS versions would be greatly appreciated.

Download (Updated to 684f371): HeliPort.zip

Not implemented

  • Key equivalent for quitting
  • Display key equivalent for quitting
  • Display state for auto launch

@williambj1 williambj1 added enhancement New feature or request help wanted Extra attention is needed labels Aug 3, 2024
@williambj1 williambj1 self-assigned this Aug 3, 2024
@williambj1
Introduce new UI
449bf10 
- Refactor StatusMenu.swift
- Optimize performance for updating the network list
- Optimize performance for highlighting menu items via private APIs
@perez987
Copy link
Contributor

perez987 commented Aug 4, 2024

@williambj1
This is the summary on 3 systems (13, 14 and 15), I delete my previous posts.

macOS Ventura 13.6.8

  • Switching appearance works fine.
  • Legacy UI: everything is okay.
  • Modern UI: always starts in extended mode, like when we press the Alt key. Few Spanish translations missing.

macOS Sonoma 14.6

  • Switching appearance works fine.
  • Legacy UI: everything is okay.
  • Modern UI: starts in normal mode if you don't press the Alt key and in extended mode when you press the Alt key, as expected. Few Spanish translations missing.

macOS 15 Sequoia beta 4

  • Switching appearance works fine.
  • Legacy UI: everything is okay.
  • Modern UI: starts in normal mode if you don't press the Alt key and in extended mode when you press the Alt key, as expected. Few Spanish translations missing.

@williambj1
Copy link
Collaborator Author

@williambj1 This is the summary on 3 systems (13, 14 and 15), I delete my previous posts.

macOS Ventura 13.6.8

  • Switching appearance works fine.
  • Legacy UI: everything is okay.
  • Modern UI: always starts in extended mode, like when we press the Alt key. Few Spanish translations missing.

macOS Sonoma 14.6

  • Switching appearance works fine.
  • Legacy UI: everything is okay.
  • Modern UI: starts in normal mode if you don't press the Alt key and in extended mode when you press the Alt key, as expected. Few Spanish translations missing.

macOS 15 Sequoia beta 4

  • Switching appearance works fine.
  • Legacy UI: everything is okay.
  • Modern UI: starts in normal mode if you don't press the Alt key and in extended mode when you press the Alt key, as expected. Few Spanish translations missing.

Thanks for the feedback! I’ve installed VMs for both macOS 12 and 13 to investigate and address the glitch.

@williambj1
Copy link
Collaborator Author

williambj1 commented Aug 4, 2024 •
edited
Loading

@perez987 I've implemented a fix. If convenient, would you mind giving it a try? (download link updated in the first post) Only one test on macOS 13 is required.

@williambj1 williambj1 mentioned this pull request Aug 4, 2024
Merged
@perez987
Copy link
Contributor

perez987 commented Aug 4, 2024

@williambj1
Yes, issue is fixed. Tried on Ventura 13.6.8, Modern UI starts as extended mode only if Alt key is pressed. It's okay now.

Simple menu

Modern-simple

Extended menu

Modern-extended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@williambj1 williambj1

Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williambj1 @perez987