remove superfluous check on return_to in oidc_refresh_token_request

Signed-off-by: Hans Zandbelt <[email protected]>
OpenIDC · Dec 13, 2024 · 65d6860 · 65d6860
1 parent 3e7c351
commit 65d6860
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/handle/refresh.c b/src/handle/refresh.c
@@ -377,10 +377,9 @@ int oidc_refresh_token_request(request_rec *r, oidc_cfg_t *c, oidc_session_t *se
 
 	/* pass optional error message to the return URL */
 	if (error_code != NULL)
-		return_to =
-		    apr_psprintf(r->pool, "%s%serror_code=%s", return_to,
-				 strchr(return_to ? return_to : "", OIDC_CHAR_QUERY) ? OIDC_STR_AMP : OIDC_STR_QUERY,
-				 oidc_http_url_encode(r, error_code));
+		return_to = apr_psprintf(r->pool, "%s%serror_code=%s", return_to,
+					 strchr(return_to, OIDC_CHAR_QUERY) ? OIDC_STR_AMP : OIDC_STR_QUERY,
+					 oidc_http_url_encode(r, error_code));
 
 	/* add the redirect location header */
 	oidc_http_hdr_out_location_set(r, return_to);