-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commcare: update documentation #814
Conversation
Signed-off-by: Hunter Achieng <[email protected]>
55f99ce
to
df819db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a bit of pasted code that needs removing please
Signed-off-by: Hunter Achieng <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Aleksa said something about configuration in the issue - is that anything that needs addressing here?
Not really, the configuration docs is accurate and up to date |
@hunterachieng what about the Sample Configuration? Should that have a user/pass or apikey? Just as a starting point for users. Maybe an app id too? @josephjclark This has been fixed |
Signed-off-by: Hunter Achieng <[email protected]>
Signed-off-by: Hunter Achieng <[email protected]>
@hunterachieng Oh I see, the sample configuration comes from required keys. hmm. We can't make username and password required, because they're not required if you pass an API key. So we'll have to live without those in the example. I presume appId is always required though? What about hostURL? Is that really required or can we (do we?) safely default that to commcarehq? |
Signed-off-by: Hunter Achieng <[email protected]>
@josephjclark hostURL is a required field |
Ok @hunterachieng , thank you! I'll get this merged in a minute |
Summary
Update
commcare
documentation with more examples and better formattingFixes #775
Details
Add more examples and update the
commcare
documentationAI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Review Checklist
Before merging, the reviewer should check the following items:
dev only changes don't need a changeset.