Fix medicmobile #334
Merged
Fix medicmobile #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overring encode-uri-component didn't seem to be playing ball
|
This looks good 👍🏽 @josephjclark |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps the
query-stringdependency ofmedicmobile.Although
query-stringgoes up several major versions, really its just because of keeping track with node versions. Looking over the history I don't think there's anything for us to worry about - we just get better quality and safer query string parsing.Note: I originally wanted to just bump the affected library
encode-uri-component- but adding the override didn't seem to work in my test project 🤔 Looking over thequery-stringchanges I'm sure this is a safe alternative.This closes #328 and allows us to close the related security advisory.