Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Curso private controller and Curso refactor #69

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

paulofelipefeitosa
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #69 into private-controllers will decrease coverage by 0.3%.
The diff coverage is 37.93%.

Impacted file tree graph

@@                    Coverage Diff                    @@
##             private-controllers      #69      +/-   ##
=========================================================
- Coverage                  80.42%   80.11%   -0.31%     
- Complexity                   281      284       +3     
=========================================================
  Files                         36       38       +2     
  Lines                        664      674      +10     
  Branches                      80       80              
=========================================================
+ Hits                         534      540       +6     
- Misses                        86       89       +3     
- Partials                      44       45       +1
Impacted Files Coverage Δ Complexity Δ
...openenade/api/modalidade/ModalidadeController.java 50% <ø> (ø) 1 <0> (ø) ⬇️
...e/api/categoriaadmin/CategoriaAdminController.java 50% <ø> (ø) 1 <0> (ø) ⬇️
...rc/main/java/br/com/openenade/api/curso/Curso.java 81.08% <ø> (ø) 15 <0> (ø) ⬇️
...penenade/api/universidade/UniversidadeService.java 90.32% <0%> (+7.96%) 14 <0> (ø) ⬇️
...om/openenade/api/modalidade/ModalidadeService.java 0% <0%> (ø) 0 <0> (?)
...m/openenade/api/categoriaadmin/CategoriaAdmin.java 75% <100%> (ø) 3 <0> (ø) ⬇️
...va/br/com/openenade/api/modalidade/Modalidade.java 80% <100%> (+2.22%) 3 <2> (ø) ⬇️
...om/openenade/api/curso/PrivateCursoController.java 20% <20%> (ø) 1 <1> (?)
...com/openenade/api/curso/PublicCursoController.java 33.33% <33.33%> (ø) 1 <1> (?)
.../java/br/com/openenade/api/curso/CursoService.java 75% <57.14%> (-25%) 5 <1> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9f337...38624e6. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #69 into master will decrease coverage by 0.3%.
The diff coverage is 37.93%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #69      +/-   ##
============================================
- Coverage     80.42%   80.11%   -0.31%     
- Complexity      281      284       +3     
============================================
  Files            36       38       +2     
  Lines           664      674      +10     
  Branches         80       80              
============================================
+ Hits            534      540       +6     
- Misses           86       89       +3     
- Partials         44       45       +1
Impacted Files Coverage Δ Complexity Δ
...openenade/api/modalidade/ModalidadeController.java 50% <ø> (ø) 1 <0> (ø) ⬇️
...e/api/categoriaadmin/CategoriaAdminController.java 50% <ø> (ø) 1 <0> (ø) ⬇️
...rc/main/java/br/com/openenade/api/curso/Curso.java 81.08% <ø> (ø) 15 <0> (ø) ⬇️
...penenade/api/universidade/UniversidadeService.java 90.32% <0%> (+7.96%) 14 <0> (ø) ⬇️
...om/openenade/api/modalidade/ModalidadeService.java 0% <0%> (ø) 0 <0> (?)
...m/openenade/api/categoriaadmin/CategoriaAdmin.java 75% <100%> (ø) 3 <0> (ø) ⬇️
...va/br/com/openenade/api/modalidade/Modalidade.java 80% <100%> (+2.22%) 3 <2> (ø) ⬇️
...om/openenade/api/curso/PrivateCursoController.java 20% <20%> (ø) 1 <1> (?)
...com/openenade/api/curso/PublicCursoController.java 33.33% <33.33%> (ø) 1 <1> (?)
.../java/br/com/openenade/api/curso/CursoService.java 75% <57.14%> (-25%) 5 <1> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9f337...477d863. Read the comment docs.

@paulofelipefeitosa
Copy link
Member Author

This pull request introduces 1 alert when merging 38624e6 into be9f337 - view on LGTM.com

new alerts:

  • 1 for Array index out of bounds

Comment posted by LGTM.com

@paulofelipefeitosa paulofelipefeitosa changed the base branch from private-controllers to master March 3, 2019 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants