Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Popover event menu support for FAB_REPLACEMENT feature flag #8873

Open
wants to merge 1 commit into
base: release/6.4.0
Choose a base branch
from

Conversation

ParamConstructor
Copy link
Contributor

@ParamConstructor ParamConstructor commented Nov 1, 2024

Proposed changes

These changes apply to the Events menu items in support of the popover removal as part of the FAB_REPLACEMENT feature flag.

  • Remove the ... popover icon.
  • Move the "Delete" from this popover into the Drawer for the item, have the button be on the bottom left of the drawer in red
    • Note - Sightings already has delete on drawer by default.
  • Float the Enrich option to the top row and use the default cloud enrichment icon

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.60%. Comparing base (3553065) to head (8a63da4).

Additional details and impacted files
@@                Coverage Diff                @@
##           release/6.4.0    #8873      +/-   ##
=================================================
- Coverage          64.61%   64.60%   -0.01%     
=================================================
  Files                614      614              
  Lines              58862    58862              
  Branches            6475     6475              
=================================================
- Hits               38031    38029       -2     
- Misses             20831    20833       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ParamConstructor ParamConstructor changed the title [frontend] Updated event menu items to support FAB_REPLACEMENT feature flag [frontend] Popover support event menu to support FAB_REPLACEMENT feature flag Nov 1, 2024
@ParamConstructor ParamConstructor changed the title [frontend] Popover support event menu to support FAB_REPLACEMENT feature flag [frontend] Popover event menu support for FAB_REPLACEMENT feature flag Nov 1, 2024
@ParamConstructor ParamConstructor marked this pull request as ready for review November 1, 2024 16:45
@aHenryJard aHenryJard added the community use to identify PR from community label Nov 12, 2024
@Bonsai8863 Bonsai8863 force-pushed the popover-removal-events branch 2 times, most recently from 5263106 to 33f214c Compare November 13, 2024 18:31
…te under the update button behind the fabreplaced feature flag

Signed-off-by: daimyo007 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community use to identify PR from community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants