-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update resource #710
update resource #710
Conversation
deploy/all_in_one/docker-compose.yml
Outdated
@@ -133,7 +133,7 @@ services: | |||
STARHUB_SERVER_API_TOKEN: ${HUB_SERVER_API_TOKEN} | |||
STARHUB_SERVER_S3_ACCESS_KEY_ID: admin | |||
STARHUB_SERVER_S3_ACCESS_KEY_SECRET: Password_123 | |||
STARHUB_SERVER_S3_ENDPOINT: ${SERVER_DOMAIN}:9000 # used to generate download links for lfs files | |||
STARHUB_SERVER_S3_ENDPOINT: ${SERVER_INTERNAL_DOMAIN:-${SERVER_DOMAIN}}:9000 # used to generate download links for lfs files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
使用这个内部域名生成的下载链接,给到portal后,用户可以下载下来吗?用户客户端得解析出来这个内部域名
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“csghub_server”服务中的STARHUB_SERVER_S3_ENDPOINT
环境变量会用于组装lfs下载地址,返回给portal,让用户下载,必须得是个公共可访问的url,只能用SERVER_DOMAIN
吧? 新增加的SERVER_INTERNAL_DOMAIN
是个内部域名(或者内网ip),用在“mirror-lfs-sync”服务的STARHUB_SERVER_S3_ENDPOINT
环境变量比较合适,用于多源同步时候往当前csghub的s3写入信息,内部域名效率高。 @pulltheflower @ganisback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this solution, still use public domain to download model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary.
Test A
Test B
Logs
Special notes for your reviewer:
Checklist:
Release note: