Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update resource #710

Merged
merged 3 commits into from
Oct 12, 2024
Merged

update resource #710

merged 3 commits into from
Oct 12, 2024

Conversation

ganisback
Copy link
Collaborator

@ganisback ganisback commented Oct 11, 2024

What this PR does:

Which issue(s) this PR fixes:

Fixes #

  1. add normal memory resource for llm, add 2gpu resource
  2. support download model with internal domain
  3. add default knative domian address

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

Checklist:

  • I have added unit/e2e tests that prove your fix is effective or that this feature works.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have reviewed my own code and ensured that it follows the project's style guidelines.

Release note:


@ganisback ganisback marked this pull request as draft October 12, 2024 00:04
@@ -133,7 +133,7 @@ services:
STARHUB_SERVER_API_TOKEN: ${HUB_SERVER_API_TOKEN}
STARHUB_SERVER_S3_ACCESS_KEY_ID: admin
STARHUB_SERVER_S3_ACCESS_KEY_SECRET: Password_123
STARHUB_SERVER_S3_ENDPOINT: ${SERVER_DOMAIN}:9000 # used to generate download links for lfs files
STARHUB_SERVER_S3_ENDPOINT: ${SERVER_INTERNAL_DOMAIN:-${SERVER_DOMAIN}}:9000 # used to generate download links for lfs files
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用这个内部域名生成的下载链接,给到portal后,用户可以下载下来吗?用户客户端得解析出来这个内部域名

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“csghub_server”服务中的STARHUB_SERVER_S3_ENDPOINT环境变量会用于组装lfs下载地址,返回给portal,让用户下载,必须得是个公共可访问的url,只能用SERVER_DOMAIN吧? 新增加的SERVER_INTERNAL_DOMAIN是个内部域名(或者内网ip),用在“mirror-lfs-sync”服务的STARHUB_SERVER_S3_ENDPOINT环境变量比较合适,用于多源同步时候往当前csghub的s3写入信息,内部域名效率高。 @pulltheflower @ganisback

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed this solution, still use public domain to download model

@ganisback ganisback marked this pull request as ready for review October 12, 2024 06:48
Copy link
Collaborator

@wayneliu0019 wayneliu0019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ganisback ganisback merged commit 0b5a91b into main Oct 12, 2024
3 checks passed
@ganisback ganisback deleted the update-resource branch October 12, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants