Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add two sync services for sync function #687

Merged
merged 1 commit into from
Sep 27, 2024
Merged

add two sync services for sync function #687

merged 1 commit into from
Sep 27, 2024

Conversation

wayneliu0019
Copy link
Collaborator

@wayneliu0019 wayneliu0019 commented Sep 26, 2024 •
edited
Loading

Type of changes

  1. add two sync services for sync function
  2. modify some env variable default values
  • Bug fix (non-breaking change which fixes an issue)

Feature/Issue validation/testing:

  • Logs

Special notes for your reviewer:
please check whether the commits are correct or not

@wayneliu0019 wayneliu0019 self-assigned this Sep 26, 2024
hiveer
hiveer approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@hiveer hiveer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiveer hiveer merged commit 1754ba1 into main Sep 27, 2024
3 checks passed
@hiveer hiveer deleted the wayneliu0019-patch-2 branch September 27, 2024 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiveer hiveer hiveer approved these changes

@pulltheflower pulltheflower Awaiting requested review from pulltheflower

Assignees

@wayneliu0019 wayneliu0019

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wayneliu0019 @hiveer