Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New fine tuning instance model ID input box Error message adjustment #678

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

zzxr6
Copy link
Collaborator

@zzxr6 zzxr6 commented Sep 26, 2024

What this PR does:New fine tuning instance model ID input box Error message adjustment

Which issue(s) this PR fixes:https://git-devops.opencsg.com/product/community/open-portal/-/issues/1053

Fixes #

Type of changes
Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Feature/Issue validation/testing:

Please describe the tests that you ran to verify your changes and relevant result summary.

  • Test A

  • Test B

  • Logs

Special notes for your reviewer:

Checklist:

  • I have added unit/e2e tests that prove your fix is effective or that this feature works.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • I have reviewed my own code and ensured that it follows the project's style guidelines.

Release note:


@zzxr6 zzxr6 self-assigned this Sep 26, 2024
@zzxr6 zzxr6 marked this pull request as draft September 26, 2024 05:36
@zzxr6 zzxr6 marked this pull request as ready for review September 26, 2024 05:37
@zzxr6 zzxr6 changed the title 新建微调实例模型ID输入框错误提示调整 New fine tuning instance model ID input box Error message adjustment Sep 26, 2024
@@ -269,6 +269,12 @@
{
required: true,
message: t('all.pleaseInput', { value: t('endpoints.new.modelId') }),
trigger: 'change'
},
// 确保字符串中包含一个 /,但不能出现在首位或末尾
Copy link
Collaborator

@hiveer hiveer Sep 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove Chinese

Copy link
Collaborator

@hiveer hiveer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiveer hiveer merged commit de71e45 into main Sep 27, 2024
3 checks passed
@hiveer hiveer deleted the csghub__fix-model-id branch September 27, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants