Enable CI for pull request #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rader
reviewed
Sep 23, 2024
|
|
||
| on: | ||
| pull_request: | ||
| branches: [ main ] |
There was a problem hiding this comment.
can we support UT on the source branch of current PR?
There was a problem hiding this comment.
@Rader This "branch" refers to the target branch. That means the workflow is only triggered when the target branch of the PR is the "main" branch, instead of dev branch.
jasonhe258
force-pushed
the
enable_ci
branch
from
ba03fc7 to
21b792d
Compare
Rader
approved these changes
Sep 24, 2024
hiveer
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Enable CI for pull request * update go version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MR is going to enable CI for new pull request. Please note that this just enable process without the CI test case, integration cases and lint checking, the cases will be created in the future.