Skip Flushing Instruction Cache on x86 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cargo: Set default targets as Windows Updated: Script to run `wine` on host, for faster testing.
This is 'technically correct', and also fixes Wine.
* This is needed for architectures with a separate instruction and data cache. * In x86 and x64 these are unified, so this is not necessary. * If it turns out this is needed for e.g. x64 emulation on ARM64, it may be re-enabled one day.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on:
So please address that first, as changes from that PR will show as a diff here otherwise.
This PR skips calls to
flush_instruction_cacheon x86 based architectures. (Left them in for other platforms, in case we ever decide to support ARM64 etc.)About this PR: