Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backend/frontend] Merge tabs in scenario form (#1822) #1828

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[backend/frontend] Merge tabs in scenario form (#1822) #1828

wants to merge 11 commits into from

Conversation

johanah29
Copy link
Member

No description provided.

@johanah29 johanah29 self-assigned this Nov 7, 2024
@johanah29 johanah29 linked an issue Nov 7, 2024 that may be closed by this pull request
Update scenario drawer - merge 2 tabs overview and mail configuration together #1822
Open
@johanah29
Copy link
Member Author

#1822

@johanah29 johanah29 changed the title [Backend|Frontend]Merge tabs in scenario form [Backend|Frontend]Merge tabs in scenario form (#1822) Nov 7, 2024
@guillaumejparis guillaumejparis changed the title [Backend|Frontend]Merge tabs in scenario form (#1822) [backend/frontend] Merge tabs in scenario form (#1822) Nov 8, 2024
@johanah29 johanah29 marked this pull request as ready for review November 8, 2024 13:41
@johanah29 johanah29 force-pushed the bugfix/1822 branch 3 times, most recently from 9c59077 to fceed9d Compare November 13, 2024 08:27
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 32.50%. Comparing base (6e03516) to head (5bd1447).

Files with missing lines Patch % Lines
...enbas/rest/settings/response/PlatformSettings.java 0.00% 2 Missing ⚠️
...va/io/openbas/service/PlatformSettingsService.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1828      +/-   ##
============================================
+ Coverage     32.42%   32.50%   +0.07%     
- Complexity     1623     1629       +6     
============================================
  Files           561      561              
  Lines         16834    16843       +9     
  Branches        984      984              
============================================
+ Hits           5459     5474      +15     
+ Misses        11133    11127       -6     
  Partials        242      242

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johanah29 johanah29 force-pushed the bugfix/1822 branch 2 times, most recently from 82ade84 to acdcff8 Compare November 13, 2024 13:26
@savacano28 savacano28 added the filigran team use to identify PR from the Filigran team label Nov 13, 2024
@guillaumejparis
Copy link
Member

I've retested : when creating a scenario changes in mail fields are not saved
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guillaumejparis guillaumejparis Awaiting requested review from guillaumejparis

@savacano28 savacano28 Awaiting requested review from savacano28

At least 1 approving review is required to merge this pull request.

Assignees

@johanah29 johanah29

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update scenario drawer - merge 2 tabs overview and mail configuration together
3 participants
@johanah29 @guillaumejparis @savacano28