[backend/frontend] enforce null consistency with executor and command (#1621) #1825
Conversation
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1825 +/- ##
============================================
+ Coverage 32.08% 32.31% +0.22%
+ Complexity 1609 1605 -4
============================================
Files 561 562 +1
Lines 16850 17049 +199
Branches 974 1019 +45
============================================
+ Hits 5406 5509 +103
- Misses 11200 11291 +91
- Partials 244 249 +5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
| @@ -2680,6 +2681,7 @@ const i18n = { | |||
| 'Update the security platform': '更新安全平台', | |||
| 'Security Platforms': '安全平台', | |||
| 'Content should not be empty': '内容不可为空', | |||
| 'Cleanup command and executor must be defined together or none at all': '清理命令和执行器必须一起定义，否则根本无法定义', | |||
antoinemzs
changed the title
|
Issue found: the new constraint prevents importing the atomic red team database |
fixed |
|
nitpick: When I try to update a payload (image 1), I receive errors for all the mandatory fields, but not for the scenario where only one of two fields is filled, so maybe it is possible to add this verification?
Question: When I create a payload with a type other than 'executable type,' I receive all the expected errors, but for 'executable type,' I don't. Could you please verify why the behavior is different?
|
| @@ -158,4 +279,20 @@ private PayloadCreateInput getExecutablePayloadCreateInput() { | |||
| input.setExecutableArch(Endpoint.PLATFORM_ARCH.x86_64); | |||
| return input; | |||
| } | |||
|
|
|||
| private PayloadCreateInput getCommandLinePayloadCreateInput() { | |||
| PayloadCreateInput input = new PayloadCreateInput(); | |||
There was a problem hiding this comment.
nitpick: Maybe use a fixture?
| SET command_executor = NULL, command_content = NULL | ||
| WHERE (command_executor = '') IS NOT FALSE OR (command_content = '') IS NOT FALSE | ||
| """); | ||
| migrator.execute( |
There was a problem hiding this comment.
praise: Thanks for adding this constraint
Proposed changes
Related issues
Checklist
Further comments
On the payload definition panel, it is now not possible to only define the cleanup executor or the cleanup command. Both must be defined at the same time or none of them (i.e. blank fields).
The backend part was done with a "pure" null philosophy, unfortunately the frontend is not yet able to handle null values in react field components: the frontend special cases empty string for fields to submit null instead.