Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix git tag specification in pio lib dependencies #253

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

julianneswinoga
Copy link
Member

@ specifiers are not valid for git dependencies (only PlatformIO dependencies). Example 5 here: https://docs.platformio.org/en/latest/core/userguide/pkg/cmd_install.html#repository-git-hg-svn

Copy link
Member

@ClutchplateDude ClutchplateDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julianneswinoga julianneswinoga force-pushed the jswinoga/fix/use-proper-git-tags branch from aed6dce to 35523a9 Compare November 17, 2024 17:37
@julianneswinoga julianneswinoga merged commit 5e7e3eb into develop Nov 17, 2024
8 checks passed
@julianneswinoga julianneswinoga deleted the jswinoga/fix/use-proper-git-tags branch November 17, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants