rpmsg_virtio: fix the rpmsg_get_tx/rx_buffer() api #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user tx/rx buffer size = orignal tx/rx buffer_size - sizeof(rpmsg_hdr) And use buffer size in config to calculate the user buffer size instead the buffer size from virtqueue, because there may be no buffer in virtqueeu. Signed-off-by: Tao Yin <[email protected]> Signed-off-by: Bowen Wang <[email protected]>
Please clarify your need because you are breaking the expected behavior: returning 0 if no buffer is available. |
|
This pull request has been marked as a stale pull request because it has been open (more than) 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user tx/rx buffer size = orignal tx/rx buffer_size - sizeof(rpmsg_hdr)
And use buffer size in config to calculate the user buffer size instead the buffer size from virtqueue, because there may be no buffer in virtqueue.