linux: Remove namespace for DesktopBrowserLauncher

Update the function name to be more descriptive so we don't need a namespace wrapping a single function. Signed-off-by: Open592 Developer <[email protected]>
Open592 · Feb 25, 2024 · 5843292 · 5843292
1 parent fee9952
commit 5843292
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 11 deletions.
diff --git a/src/platform/linux/BrowserHandler.cpp b/src/platform/linux/BrowserHandler.cpp
@@ -33,7 +33,7 @@ bool BrowserHandler::OnBeforePopup(CefRefPtr<CefBrowser> browser, CefRefPtr<CefF
     CEF_REQUIRE_UI_THREAD()
 
     // Best effort call
-    DesktopBrowserLauncher::Open(target_url);
+    tryOpenUrlInDesktopBrowser(target_url);
 
     // Block popups
     return true;

diff --git a/src/platform/linux/DesktopBrowserLauncher.cpp b/src/platform/linux/DesktopBrowserLauncher.cpp
@@ -95,9 +95,7 @@ const std::optional<std::string> g_desktopBrowserCommand = resolveBrowserCommand
 
 }
 
-namespace DesktopBrowserLauncher {
-
-bool Open(const std::string& URL)
+bool tryOpenUrlInDesktopBrowser(const std::string& URL)
 {
     if (!g_desktopBrowserCommand.has_value()) {
         return false;
@@ -116,5 +114,3 @@ bool Open(const std::string& URL)
 
     return false;
 }
-
-}
diff --git a/src/platform/linux/DesktopBrowserLauncher.hpp b/src/platform/linux/DesktopBrowserLauncher.hpp
@@ -4,8 +4,4 @@
 
 #include <string>
 
-namespace DesktopBrowserLauncher {
-
-bool Open(const std::string&);
-
-}
+bool tryOpenUrlInDesktopBrowser(const std::string& URL);