improved the web accesibility on the forms #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for oscksa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Brilliant, thank you for paying attention to the accessibilty! |
|
I couldn't determine any contributions to add, did you specify any contributions? I've put up a pull request to add @jesutobi! 🎉 |
BatoolMM
approved these changes
Oct 24, 2022
|
We will merge it now! |
you are welcome ,thank you for taking your time to review |
|
I've put up a pull request to add @you! 🎉 @jesutobi already contributed before to a11y |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #157 @BatoolMM i improved the form accesibilty by adding the aria-label attribute to each input space ,this would help screen readers when people with disabilities are using OSCSA website