Normalize files #2334
Normalize files #2334
Conversation
matrss
force-pushed
the
normalize-files
branch
2 times, most recently
from
419e332 to
df25ea2
Compare
Whitespace issues as understood by git (by default) are trailing whitespace at EOL, whitespace on an otherwise empty line, a space character immediately followed by a tab character in the indentation of a line, and multiple newlines at EOF. References: - https://git-scm.com/docs/git-diff#Documentation/git-diff.txt---check - https://peter.eisentraut.org/blog/2014/11/04/checking-whitespace-with-git
matrss
force-pushed
the
normalize-files
branch
5 times, most recently
from
17de130 to
18fe4b9
Compare
|
For a diff of what meaningfully changed you can do |
| name: lint | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
should we add here also new GSOC branches?
There was a problem hiding this comment.
Yes. This is already the case for the python-flake8 workflow on develop, but since this is on stable I missed it. Again, the issue of having two development branches. I'll fix this up. EDIT: actually, this is something that needs to be fixed when merging stable into develop. flake8-builtins is also missing here and needs to be considered when merging.
There was a problem hiding this comment.
ok on the next merge of develop to stable we have a new major release and also both branches have a similiar test infrastructure.
And yes stable is the branch we do release from. We have a major develop branch and sometimes based on that other feature branches. That is no issue.
There was a problem hiding this comment.
ok on the next merge of develop to stable we have a new major release and also both branches have a similiar test infrastructure.
I am not sure if you misunderstood me. I was talking about the next merge from stable to develop, i.e. what should happen right after this PR has been merged, not on the next merge from develop to stable (a major release). These differences between the python-flake8.yml workflow on stable and the python-flake8.yml workflow on develop need to be accounted for in the merge of stable into develop.
|
sorry for the delay, had also an idea for another check, see #2338 I added few remarks and questions. |
|
need to change rules. The flake8 mandatory check job was named lint only. |
Add lint rules to avoid having CRLF endings in the repository and to prevent trailing whitespace at EOL and duplicate newlines at EOF.
Fixes #2330.