Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker image creation from develop branch #2296

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

matrss
Copy link
Collaborator

@matrss matrss commented Mar 22, 2024

This changes the testing-develop.yml workflow to be triggered via workflow_dispatch, as is also already done for testing-stable.yml, and changes the logic in testing.yml to always rebuild the environment for runs triggered by workflow_dispatch, while only triggering image rebuilds on push events.

Part of a fix for #2258.

@matrss matrss force-pushed the fix-docker-image-creation-develop branch from 0d229ad to 681107f Compare March 22, 2024 14:18
This changes the testing-develop.yml workflow to be triggered via
workflow_dispatch, as is also already done for testing-stable.yml, and
changes the logic in testing.yml to always rebuild the environment for
runs triggered by workflow_dispatch, while only triggering image
rebuilds on push events.
@matrss matrss force-pushed the fix-docker-image-creation-develop branch from 681107f to 84e8ef3 Compare March 26, 2024 08:48
@matrss
Copy link
Collaborator Author

matrss commented Mar 26, 2024

The coverage check is red because the coverage is unfortunately still not deterministic, for some reason... So it is more or less random if it succeeds or fails.

@matrss matrss marked this pull request as ready for review March 26, 2024 09:04
@matrss matrss requested a review from joernu76 March 26, 2024 09:08
@joernu76 joernu76 merged commit e50e258 into Open-MSS:develop Mar 26, 2024
10 of 11 checks passed
@matrss matrss deleted the fix-docker-image-creation-develop branch March 26, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants