Run the test suite on Windows runners #2290
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matrss
force-pushed
the
test-on-windows
branch
3 times, most recently
from
4ee11af to
bf8bf04
Compare
The macOS 13 runners use Intel processors while the macOS 14 runners use Apple's ARM processors.
The test_tutorial_dir seems to be able to run into a 30 second timeout under normal operation on the macOS 14 runners, so this increases the timeout a bit to accommodate.
|
The test suite is completely broken on Windows at this point (>200 errors), and I don't want to spend too much time on a bad OS that I dislike. So I am closing this PR and if anyone else wants to try to fix these Windows problems feel free to pick the issue up. I think the issues are mostly related to how Windows handles the filesystem differently, e.g. you can't delete files that are still in use while on Linux/macOS that is not a problem. There is probably quite a bit in the cleanup code for tests that needs to be adapted to work on Windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2286.
Depends on #2249.