fix: Resolve warning of TypeDecorator AwareDateTime() in chat_manager.py and file_manager.py
#2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReimarBauer
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Please enable debugging if caching works. In production sqlite is rather not used, someone wants to check this in a staging setup for a production system.
We need a new SQLALCHEMY_ECHO config attribute. This should be for testing set to True and for production False.
https://flask-sqlalchemy.palletsprojects.com/en/2.x/config/
You need to change conftest, conf, app definition and documentation
locally you can test this then by pytest -s for a server test
Signed-off-by: Myrausman <[email protected]>
Signed-off-by: Myrausman <[email protected]>
|
@Myrausman please have a look on the flake8 failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2270
removes the warning
Checklist:
<type>: <subject>