Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow_dispatch trigger to enable manual stable tests #2197

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Add workflow_dispatch trigger to enable manual stable tests #2197

merged 3 commits into from
Feb 15, 2024

Conversation

rohit2p
Copy link
Contributor

@rohit2p rohit2p commented Feb 13, 2024

Purpose of PR?:
This pull request builds upon my previous change in PR #2196
I've added the workflow_dispatch: trigger to the testing-stable.yml file on the stable branch. This allows manual triggering of stable tests, improving testing flexibility and control.

Fixes #2172

Checklist:

@rohit2p
Copy link
Contributor Author

rohit2p commented Feb 13, 2024

The error message I'm seeing is Fatal Python error: Aborted. I've checked the relevant code section but haven't been able to identify the issue.
Could you please help me understand what might be causing this failure and how to fix it?

@rohit2p
Copy link
Contributor Author

rohit2p commented Feb 13, 2024

not sure, but is it because any update regarding the actions/checkout version
image

@matrss
Copy link
Collaborator

matrss commented Feb 14, 2024

The error message I'm seeing is Fatal Python error: Aborted. I've checked the relevant code section but haven't been able to identify the issue. Could you please help me understand what might be causing this failure and how to fix it?

This is happening on the stable branch already without this PR, and I don't know yet what is broken there. This PR certainly did not cause it.

not sure, but is it because any update regarding the actions/checkout version image

This warning is also unrelated to this PR, the actions/checkout version needs to be updated.

Copy link
Collaborator

@matrss matrss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rohit2p
Copy link
Contributor Author

rohit2p commented Feb 14, 2024

Thanks for your comment. Please let me know if you need anything further from me.

@ReimarBauer
Copy link
Member

Hmm, ideas why we now have these coredumps?

@matrss
Copy link
Collaborator

matrss commented Feb 15, 2024

@ReimarBauer they are happening on the stable branch already, e.g. here: https://github.com/Open-MSS/MSS/actions/runs/7854540812/job/21569532674. So that is unrelated to this PR. I am very much sure that it is because of the missing pyvirtualdisplay/xvfb-run. The issue for that is here: #2199.

@ReimarBauer
Copy link
Member

@ReimarBauer they are happening on the stable branch already, e.g. here: https://github.com/Open-MSS/MSS/actions/runs/7854540812/job/21569532674. So that is unrelated to this PR. I am very much sure that it is because of the missing pyvirtualdisplay/xvfb-run. The issue for that is here: #2199.

ok, this fix must then be first merged then we can recheck this one. With "repeating" failing tests other merge requests will be more difficult to merge.

@matrss
Copy link
Collaborator

matrss commented Feb 15, 2024

In general I'd agree, but this PR is literally a single line change that makes the workflow manually start-able, nothing else.

Slightly OT: the stable/develop split makes it so that failures on stable (i.e. the non-default branch of the two) are not as easily visible, since they show up nowhere on the repo landing page. I don't like that. Also, the change that broke the CI happened in a different repository. I also don't like that that is possible.

Anyway, I'll send a fix for the broken CI.

@ReimarBauer ReimarBauer merged commit dd40e3d into Open-MSS:stable Feb 15, 2024
4 checks passed
@rohit2p rohit2p deleted the feature/stable-manual-trigger branch February 18, 2024 13:18
ReimarBauer added a commit to ReimarBauer/MSS that referenced this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants