-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow_dispatch trigger to enable manual stable tests #2197
Add workflow_dispatch trigger to enable manual stable tests #2197
Conversation
The error message I'm seeing is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your comment. Please let me know if you need anything further from me. |
Hmm, ideas why we now have these coredumps? |
@ReimarBauer they are happening on the stable branch already, e.g. here: https://github.com/Open-MSS/MSS/actions/runs/7854540812/job/21569532674. So that is unrelated to this PR. I am very much sure that it is because of the missing pyvirtualdisplay/xvfb-run. The issue for that is here: #2199. |
ok, this fix must then be first merged then we can recheck this one. With "repeating" failing tests other merge requests will be more difficult to merge. |
In general I'd agree, but this PR is literally a single line change that makes the workflow manually start-able, nothing else. Slightly OT: the stable/develop split makes it so that failures on stable (i.e. the non-default branch of the two) are not as easily visible, since they show up nowhere on the repo landing page. I don't like that. Also, the change that broke the CI happened in a different repository. I also don't like that that is possible. Anyway, I'll send a fix for the broken CI. |
Co-authored-by: ReimarBauer <[email protected]>
Purpose of PR?:
This pull request builds upon my previous change in PR #2196
I've added the
workflow_dispatch:
trigger to thetesting-stable.yml
file on the stable branch. This allows manual triggering of stable tests, improving testing flexibility and control.Fixes #2172
Checklist: