Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled builds do not recreate the mamba environment #2258

Open
matrss opened this issue Feb 29, 2024 · 3 comments
Open

Scheduled builds do not recreate the mamba environment #2258

matrss opened this issue Feb 29, 2024 · 3 comments

Comments

@matrss
Copy link
Collaborator

matrss commented Feb 29, 2024

This step is intended to trigger a recreation of the mamba environment every time a scheduled test is done:

- name: Always rebuild dependencies for scheduled builds
if: ${{ success() && inputs.event_name == 'schedule' && inputs.branch_name == 'stable' && env.triggerdockerbuild != 'yes' }}
run: |
echo "triggerdockerbuild=yes" >> $GITHUB_ENV

There are some issues with it:

  1. The condition is always false for develop, so scheduled tests on develop would not always recreate the environment
  2. Since Fix: Scheduled test now triggers testing-stable.yml using workflow_dispatch #2196 was merged the condition is also always false for scheduled tests on stable because the event_name is not "schedule", but "workflow_dispatch"

Also, the scheduled tests never trigger a docker build because their event type is never "push", which might be another bug unless I misunderstand when the docker image builds should happen.

@matrss
Copy link
Collaborator Author

matrss commented Mar 20, 2024

@ReimarBauer do you have some input on this?

@matrss
Copy link
Collaborator Author

matrss commented Mar 21, 2024

@joernu76 this is the related issue to docker image creation.

@ReimarBauer
Copy link
Member

@matrss are the two merges related and solving this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants