Load as dataset and use name in data_vars #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soxofaan
reviewed
Dec 11, 2024
soxofaan
reviewed
Jan 8, 2025
| data = data.to_dataarray(dim=band_dim_name) | ||
| data = data.to_array(dim=band_dim_name) | ||
| except ValueError: | ||
| data = xarray.open_dataarray(path) |
There was a problem hiding this comment.
If you switch to trying open_dataset first, is it actually still necessary to do the try-except? As far as I know, open_dataset will also work on data arrays, so doing open_dataarray on except might be useless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are saving our netcdf results as xr.DataSets with the variables being either the "bands" or if no "bands" dimension is found, with the single variable "name".