Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for issue #1722 #1849

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KeilChris
Copy link
Contributor

@KeilChris KeilChris commented Nov 13, 2024

Documentation clean-up and ensuring packchk tool documentation is visible for the end user.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.92%. Comparing base (cb7fb18) to head (f54ece4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1849   +/-   ##
=======================================
  Coverage   64.92%   64.92%           
=======================================
  Files         163      163           
  Lines       34457    34457           
  Branches    19976    19976           
=======================================
  Hits        22370    22370           
  Misses       7958     7958           
  Partials     4129     4129           
Flag Coverage Δ
projmgr-cov 81.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

Test Results

    3 files     18 suites   8m 38s ⏱️
  371 tests   371 ✅ 0 💤 0 ❌
1 113 runs  1 113 ✅ 0 💤 0 ❌

Results for commit f54ece4.

@jkrech jkrech self-requested a review November 13, 2024 15:54
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check wether you want to consider my comment


**Package management** including discovery of components, devices, boards and examples:
## Package creation and validation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated to the documentation changes? Are you fixing a test case or is this a result from merging main?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to retain this as there is some proposals captured?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants