-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for issue #1722 #1849
base: main
Are you sure you want to change the base?
Update for issue #1722 #1849
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1849 +/- ##
=======================================
Coverage 64.92% 64.92%
=======================================
Files 163 163
Lines 34457 34457
Branches 19976 19976
=======================================
Hits 22370 22370
Misses 7958 7958
Partials 4129 4129
Flags with carried forward coverage won't be shown. Click here to find out more. |
Test Results 3 files 18 suites 8m 38s ⏱️ Results for commit f54ece4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check wether you want to consider my comment
|
||
**Package management** including discovery of components, devices, boards and examples: | ||
## Package creation and validation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is worth mentioning the
gen_pack
https://github.com/Open-CMSIS-Pack/gen-pack/?tab=readme-ov-file#bash-library-for-gen-pack-scripts
here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change seems unrelated to the documentation changes? Are you fixing a test case or is this a result from merging main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we need to retain this as there is some proposals captured?
Documentation clean-up and ensuring packchk tool documentation is visible for the end user.