Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projmgr, buildmgr] Shift toolchain registration enforcement from project to build management #1651

Conversation

grasci-arm
Copy link
Collaborator

@grasci-arm grasci-arm commented Jul 18, 2024

Address #1646

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.80%. Comparing base (0d2b3d0) to head (4fde508).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1651      +/-   ##
==========================================
- Coverage   63.81%   63.80%   -0.01%     
==========================================
  Files         162      162              
  Lines       31630    31617      -13     
  Branches    19388    19376      -12     
==========================================
- Hits        20184    20173      -11     
- Misses       7558     7575      +17     
+ Partials     3888     3869      -19     
Flag Coverage Δ
buildmgr-cov 74.21% <57.14%> (+0.08%) ⬆️
projmgr-cov 80.59% <68.75%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tools/buildmgr/cbuild/src/CbuildModel.cpp 74.08% <100.00%> (-0.15%) ⬇️
tools/buildmgr/cbuild/src/CbuildMsgs.cpp 100.00% <100.00%> (ø)
tools/projmgr/src/ProjMgrGenerator.cpp 88.93% <ø> (ø)
tools/projmgr/src/ProjMgrYamlEmitter.cpp 94.47% <100.00%> (+<0.01%) ⬆️
tools/projmgr/src/ProjMgrWorker.cpp 87.01% <85.71%> (-0.04%) ⬇️
...s/buildmgr/test/unittests/src/CbuildModelTests.cpp 49.18% <25.00%> (-1.46%) ⬇️
tools/projmgr/test/src/ProjMgrUnitTests.cpp 79.44% <42.85%> (-0.03%) ⬇️

... and 8 files with indirect coverage changes

Copy link

github-actions bot commented Jul 18, 2024

Test Results

  7 files   53 suites   4m 13s ⏱️
185 tests 168 ✅ 17 💤 0 ❌
692 runs  624 ✅ 68 💤 0 ❌

Results for commit 4fde508.

♻️ This comment has been updated with latest results.

@brondani brondani merged commit 21980a0 into Open-CMSIS-Pack:main Jul 18, 2024
57 of 58 checks passed
@brondani brondani deleted the outbound/devtools-shift-envvar-check branch July 18, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants