Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projmgr] List layers: introduce active connect handling #1628

Conversation

grasci-arm
Copy link
Collaborator

@grasci-arm grasci-arm commented Jul 9, 2024

Address #1621

Copy link

github-actions bot commented Jul 9, 2024

Test Results

    3 files     18 suites   7m 32s ⏱️
  357 tests   357 ✅ 0 💤 0 ❌
1 071 runs  1 071 ✅ 0 💤 0 ❌

Results for commit d39b4a2.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 78.82353% with 18 lines in your changes missing coverage. Please review.

Project coverage is 63.78%. Comparing base (65ccc21) to head (d39b4a2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
+ Coverage   63.75%   63.78%   +0.02%     
==========================================
  Files         162      162              
  Lines       31520    31586      +66     
  Branches    19316    19374      +58     
==========================================
+ Hits        20097    20146      +49     
+ Misses       7543     7539       -4     
- Partials     3880     3901      +21     
Flag Coverage Δ
projmgr-cov 80.63% <78.82%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
tools/projmgr/include/ProjMgrUtils.h 87.50% <ø> (ø)
tools/projmgr/src/ProjMgrWorker.cpp 87.00% <97.29%> (+0.11%) ⬆️
tools/projmgr/test/src/ProjMgrUnitTests.cpp 79.49% <77.77%> (-0.01%) ⬇️
tools/projmgr/test/src/ProjMgrWorkerUnitTests.cpp 65.70% <61.53%> (-0.21%) ⬇️

... and 1 file with indirect coverage changes

@brondani brondani merged commit 05e8868 into Open-CMSIS-Pack:main Jul 9, 2024
32 of 33 checks passed
@brondani brondani deleted the outbound/projmgr-list-layers-active-connect branch July 9, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants