Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[projmgr] Update list layers behaviour: load device/board specific packs #1096

Conversation

grasci-arm
Copy link
Collaborator

@grasci-arm grasci-arm commented Aug 28, 2023

Rework layer discovering initial steps for clear processing and filtering of candidate layers.
Address second issue from #1092.

@github-actions
Copy link

github-actions bot commented Aug 28, 2023

Test Results

    7 files    53 suites   5m 28s ⏱️
186 tests 169 ✔️ 17 💤 0
692 runs  624 ✔️ 68 💤 0

Results for commit 8f88be9.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #1096 (8f88be9) into main (877d5e5) will increase coverage by 0.05%.
The diff coverage is 74.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1096      +/-   ##
==========================================
+ Coverage   58.07%   58.12%   +0.05%     
==========================================
  Files         116      116              
  Lines       22820    22864      +44     
  Branches    12675    12694      +19     
==========================================
+ Hits        13252    13289      +37     
- Misses       7339     7343       +4     
- Partials     2229     2232       +3     
Flag Coverage Δ
buildmgr-cov 77.91% <ø> (ø)
packchk-cov 64.20% <ø> (ø)
projmgr-cov 82.73% <74.32%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
tools/projmgr/src/ProjMgrWorker.cpp 83.11% <73.91%> (-0.18%) ⬇️
tools/projmgr/src/ProjMgrUtils.cpp 88.23% <80.00%> (-0.17%) ⬇️

... and 1 file with indirect coverage changes

@brondani brondani merged commit 3932e32 into Open-CMSIS-Pack:main Aug 28, 2023
84 checks passed
@brondani brondani deleted the outbound/projmgr-list-layers-update branch August 28, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants