Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Choosing A Region #188 #298

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Fixed Choosing A Region #188 #298

wants to merge 2 commits into from

Conversation

VKumar786
Copy link
Contributor

Pull Request

Change Type Correction

Fixes #188

@VKumar786 VKumar786 requested a review from abhi1693 March 19, 2024 08:33
@VKumar786 VKumar786 self-assigned this Mar 19, 2024
@vercel Vercel
Copy link

vercel bot commented Mar 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cloudmydc-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 9:26am

@VKumar786 VKumar786 linked an issue Mar 21, 2024 that may be closed by this pull request
Choosing A Region #188
Open
abhi1693
abhi1693 requested changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@abhi1693 abhi1693 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incorrect image for substituition. The requirement is to show it via the topology wizard

@VKumar786 VKumar786 requested a review from yash-pal1 April 23, 2024 04:45
yash-pal1
yash-pal1 requested changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@yash-pal1 yash-pal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolve merge conflicts

@VKumar786 VKumar786 requested a review from yash-pal1 April 26, 2024 12:34
@yash-pal1 yash-pal1 requested review from yash-pal1 and abhi1693 May 1, 2024 06:00
yash-pal1
yash-pal1 requested changes May 1, 2024
View reviewed changes
Copy link
Contributor

@yash-pal1 yash-pal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this with topology region view image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash-pal1 yash-pal1 yash-pal1 requested changes

@abhi1693 abhi1693 Awaiting requested review from abhi1693

Requested changes must be addressed to merge this pull request.

Assignees

@VKumar786 VKumar786

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Choosing A Region
3 participants
@VKumar786 @abhi1693 @yash-pal1