Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: make init synchronous #41

Closed
wants to merge 1 commit into from
Closed

React: make init synchronous #41

wants to merge 1 commit into from

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented Sep 15, 2022

jkasten2
jkasten2 requested changes Mar 16, 2023
View reviewed changes
Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a breaking API change for main.

Seems like something we would only want to do in a major release.

@rgomezp rgomezp closed this Mar 17, 2023
@rgomezp rgomezp deleted the make-init-synchronous branch March 17, 2023 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkasten2 jkasten2 jkasten2 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgomezp @jkasten2