Nits

OneSignal · Jun 28, 2022 · ddfa40e · ddfa40e
1 parent 15e4daa
commit ddfa40e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/managers/FileFetchManager.ts b/src/managers/FileFetchManager.ts
@@ -3,10 +3,12 @@ import { IFunctionSignature } from "../models/FunctionSignature";
 import { createRegex, remoteFetchFile, parseFunctionSig } from "../support/utils";
 
 export class FileFetchManager {
-  static async getStubs() {
+  static async getStubs(): Promise<string[]> {
     const stubFile = await remoteFetchFile(PATHS.ONESIGNAL_STUBS);
     const regex = /FUNCTION_LIST_WITH_PROMISE_TO_STUB = \[([a-zA-Z\s,\"_]*)\]/;
-    return stubFile.match(regex)[1].split("\n    \"").join("").split("\",").join(',').split("\"\n  ").join("").split(",");
+    const match = stubFile.match(regex)[1]
+    // removes unwanted characters and returns simple array of functions
+    return match.split("\n    \"").join("").split("\",").join(',').split("\"\n  ").join("").split(",");
   }
 
   static async getFunctions(): Promise<IFunctionSignature[]> {

diff --git a/src/support/utils.ts b/src/support/utils.ts
@@ -5,7 +5,7 @@ import { IFunctionSignature } from '../models/FunctionSignature';
 
 export async function remoteFetchFile(path: string): Promise<string> {
   return await new Promise(resolve => {
-    curl.request({ url: GITHUB_URL+path }, function (err, stdout) {
+    curl.request({ url: GITHUB_URL+path }, (err, stdout) => {
       resolve(stdout);
     });
   })