Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to define custom post types #341

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sherwinski
Copy link

@sherwinski sherwinski commented Jan 8, 2025

Summary

Allows users to define custom post types via the plugin admin page.

Description

Changes include:

  • adding new input to the admin page
  • persist field values to onesignal_settings
  • toggle save button when custom post types are modified

This change is Reviewable

@sherwinski sherwinski requested a review from rgomezp January 8, 2025 20:23
@sherwinski
Copy link
Author

Open Questions

  • Reading our docs, will we need to add back this checkbox for Automatically send a push notification when I publish a post from 3rd party plugins? I imagine so based on the old implementation in v2 but figured I check first
  • Any recommendations on testing this? Are there any third-party plugins you recommend using or is this something that can be easily mocked?

@rgomezp
Copy link
Contributor

rgomezp commented Jan 8, 2025

Looking good so far!

We still need to make onesignal_schedule_notification make use of the custom post types settings.

I imagine so based on the old implementation in v2 but figured I check first

Yeah good catch. I think this will be required.

Any recommendations on testing this? Are there any third-party plugins you recommend using or is this something that can be easily mocked?

Unfortunately don't know how our customers use this. Maybe @marclucraft or @jfishman1 have some ideas. Otherwise, I think just researching is the best bet.

@marclucraft
Copy link
Contributor

@sherwinski @rgomezp – I don't have any specific plugins from Customers to suggest, although many use custom post types.

This guide will help to get some setup: https://www.cloudways.com/blog/wordpress-custom-post-type/

@marclucraft
Copy link
Contributor

Since there is work on the settings screen here, we are still seeing reports of Settings not persisting.

A customer has reached out to Support and referenced this WordPress plugin topic
https://wordpress.org/support/topic/cannot-save-option-to-send-to-mobile-app-users/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants