Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 'setMockMethodCallHandler' is deprecated | Updated minSdkVersion to 23 & compileSdkVersion to 34 #929

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

UsamaSarwar
Copy link

@UsamaSarwar UsamaSarwar commented Aug 8, 2024

Description

One Line Summary

Fixed 'setMockMethodCallHandler' is deprecated | Updated minSdkVersion to 23 & compileSdkVersion to 34

Details

[Updated] minSdkVersion to 23 in build.gradle files
[Updated] compileSdkVersion to 34 in build.gradle files
[Fixed] 'setMockMethodCallHandler' is deprecated and shouldn't be used. Use tester.binding.defaultBinaryMessenger.setMockMethodCallHandler or TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.setMockMethodCallHandler instead. Pass the channel as the first argument. This feature was deprecated after v3.9.0-19.0.pre.

Motivation

'setMockMethodCallHandler' is deprecated and needs to be updated

Scope

This PR updates the minimum supported SDK version to 23 and the compile SDK version to 34 in the build.gradle files. It also fixes a deprecation warning related to setMockMethodCallHandler.

Testing

Unit testing

Updated 'setMockMethodCallHandler' which is deprecated.

Manual testing

It's working fine

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

[Fixed] 'setMockMethodCallHandler' is deprecated and shouldn't be used. Use tester.binding.defaultBinaryMessenger.setMockMethodCallHandler or TestDefaultBinaryMessengerBinding.instance.defaultBinaryMessenger.setMockMethodCallHandler instead. Pass the channel as the first argument. This feature was deprecated after v3.9.0-19.0.pre.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant