Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS bindings for InAppMessages and Location #72

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented Oct 13, 2023

Description

One Line Summary

This PR fixes the issue with InAppMessages and Location libraries not being found properly when importing from a nuget package.

Details

Fixes #68
PR 70 attempted to fix this issue, but didn't fully resolve it. #70
The DotNet.Targets file specifies xcframeworks to be copied into native references/resources that are consumed by Xamarin and .Net.

Motivation

Fix build issue on iOS

Scope

iOS builds

Testing

Unit testing

none

Manual testing

Tested by importing the local nuget package into a test app. This is not testable using our app included in this repository.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • [ x I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

@emawby emawby merged commit e1b5edc into user-model/main Oct 16, 2023
1 check passed
@emawby emawby deleted the fix/bindings_for_modular_libraries branch October 16, 2023 22:27
@emawby emawby mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants