Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Test #343

Draft
wants to merge 37 commits into
base: onekey
Choose a base branch
from
Draft

Internal Test #343

wants to merge 37 commits into from

Conversation

ByteZhang1024
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Jul 18, 2024

PR Summary

  • Added a New Element to UI
    A watermark component was added to the App interface for branding and identification purposes. Also, the related translations for this component were included in two languages: English (US) and Chinese (zh-CN).

  • Enhanced Playground Area With Testing Elements
    Elements called TestDeviceExpect and related types have been added to the playground area, where developers and users can interactively test the software.

  • Improved Blockchain Operations Support
    The application now has an enhanced capability to interact with various blockchains. This includes Ethereum, NEM, Starcoin, and the Lightning Network. These features allow the application to manage interactions with these blockchain networks, improving the application's interoperability.

  • Crypto API Expansion
    Several functions have been added to interact with various cryptocurrencies. These additions give the application wider capabilities when dealing with different digital currencies.

  • Imported a Context Hook
    The ApplicationContext helps in managing global state throughout the app in an efficient and straightforward manner.

  • Updated Device Manager
    With additional methods, the device manager can now perform more operations, providing richer functionality for device interactions.

  • File System Changes
    New files related to different functionalities were created. Some functionalities are testing features for Bitcoin (BTC) commands like CoinJoin and Ownership. Others involve managing device operations like firmware updates and device information.

  • Device Interaction Modifications
    Several import statements were adjusted for enhanced organization and maintenance.

  • Brought in Enhanced Cryptographical Functionality
    The PR has added more files to enable the application to perform more cryptographic operations and debugging abilities. These new files provide additional computational cryptography.

  • Introduction of a Variety of Blockchain Functionalities
    A broad range of blockchain functionalities has been added regarding properties like emmc, eos, evm, and nem among others. This greatly widens the number of blockchain-related tasks our application can perform.

  • Validation Procedures
    Implemented additional validation functions for getting addresses in various languages (BTC, Aptos, etc.). These changes enhance the reliability and correctness of the application.

  • Firmware Management Enhancements
    Many firmware-related enhancements were made on components like erasing firmware, updating firmware, and uploading firmware. Thus, the application now has improved firmware management abilities.

  • Improved Ethereum Operations
    Removed the getVersionRange function in DeviceRebootToBootloader.ts. Several Ethereum operation related changes were made, hence, enhancing Ethereum operation management.

  • Validation Checks Added
    Added validations for a number of operation results. This way, it bolsters the error handling efficiency

@ByteZhang1024 ByteZhang1024 force-pushed the test/api branch 2 times, most recently from 2ffabf5 to 82b21e5 Compare July 30, 2024 05:01
Copy link

socket-security bot commented Jul 30, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

originalix and others added 9 commits September 9, 2024 13:26
chore: optimize monitor

fix: fix test error (#318)

* chore: fix 24 one pubkey

* fix: test case error

feat: DeviceUpdateBootloader support pro

chore: optimized device info

feat: add security check test

fix: dot pubkey equals

fix: old classic connect error
chore: add test api

chore: update emmc running state
Copy link

coderabbitai bot commented Oct 24, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Report too large to display inline

View full report↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants