Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: optimize cancel #340

Draft
wants to merge 1 commit into
base: onekey
Choose a base branch
from
Draft

chore: optimize cancel #340

wants to merge 1 commit into from

Conversation

ByteZhang1024
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Jul 5, 2024

PR Summary

  • Added error handling utility
    Added import declaration for error handling module in the core software. This will allow us to effectively manage errors and exceptions.

  • Created a mechanism to cancel an ongoing process
    Introduced a marker canceled in BaseMethod.ts to track whether a process was canceled halfway. This will allow us to better manage operations and increase efficiency.

  • Enhanced error messaging
    Modified the code in errors.ts to throw more specific error messages when unexpected issues occur. This will ensure better error visibility and thus quicker resolution.

  • Provision for removal of method from execution queue
    Added a removeMethodFromQueue function, which will allow a more dynamic and manageable execution flow.

  • Checks for cancellation
    Introduced checks to see if a method has been canceled, which will prevent unnecessary operations on an outdated process.

  • Added monitoring scripts
    Introduced new files monitor-config.json and monitor.js which are expected to help in monitoring the system's performance and activities. This will help us identify issues before they become major problems, ensuring more stable system operation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant