Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: air gap #320

Draft
wants to merge 1 commit into
base: onekey
Choose a base branch
from
Draft

feat: air gap #320

wants to merge 1 commit into from

Conversation

ByteZhang1024
Copy link
Contributor

No description provided.

Copy link

what-the-diff bot commented Apr 3, 2024

PR Summary

  • Introducing new screens and components
    Added various new screens and components such as AirGapScreen and ScanScreen to increase the functionality and user interface of the application.

  • Permission for Camera use
    Included permissions in the AndroidManifest.xml and app.json (for iOS) to allow the application to access the camera.

  • Maven and Package dependencies
    Integrated necessary maven and package dependencies required for the operation of expo-camera and other new functionalities.

  • New translations added
    Enhanced user accessibility by introducing new translations.

  • Modification in NavigationView
    Optimized the NavigationView component in Header.tsx to enhance user experience and navigation.

  • Modifications in core functionality
    Updated core/index.ts and Device.ts files to refine passphrase check procedures, increasing the security of the application.

  • Enhancement in HD Air-Gap SDK
    Fostered the functionality of hd-air-gap-sdk by adding multiple files that introduce new classes and types. This includes CryptoHDKey, CryptoKeypath, CryptoOutput, CryptoPSBT, MultiKey, PathComponent, ScriptExpression, RegistryItem, RegistryType and many more.

  • Addition of Registry Types
    As part of the SDK enhancement, new registry types like CRYPTO_HDKEY, CRYPTO_KEYPATH, CRYPTO_COIN_INFO, ETH_SIGN_REQUEST, ETH_SIGNATURE, ETH_NFT_ITEM etc., have been introduced.

In essence, this PR includes changes that focus on enhancing user interface, accessibility, and security, as well as expanding the functionality of the hd-air-gap-sdk component.

Copy link

socket-security bot commented Apr 3, 2024

@ByteZhang1024 ByteZhang1024 force-pushed the feat/air-gap branch 2 times, most recently from 418afa2 to 9e0d580 Compare April 3, 2024 01:37
@ByteZhang1024 ByteZhang1024 marked this pull request as draft June 6, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant