Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds string field for web statistics url #1638

Merged
merged 4 commits into from
Dec 31, 2024

Conversation

Tschuppi81
Copy link
Contributor

Settings: Displays the web statistics url

TYPE: Feature
LINK: ogc-1639

Copy link

linear bot commented Dec 30, 2024

Copy link

codecov bot commented Dec 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (eb0b55a) to head (77935dc).
Report is 3 commits behind head on master.

Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/form/fields.py 96.17% <100.00%> (+0.02%) ⬆️
src/onegov/form/widgets.py 84.18% <100.00%> (+0.32%) ⬆️
src/onegov/org/forms/settings.py 80.78% <100.00%> (+0.60%) ⬆️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb0b55a...77935dc. Read the comment docs.

@Tschuppi81
Copy link
Contributor Author

Matomo:
Screenshot from 2024-12-31 07-53-25

Plausible
Screenshot from 2024-12-31 07-53-44

Is there a better way I could do it?

Copy link
Contributor

@BreathingFlesh BreathingFlesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But you could use a panel instead so the link is clickable.

@Tschuppi81
Copy link
Contributor Author

Tschuppi81 commented Dec 31, 2024

with clickable url in panel
Screenshot from 2024-12-31 09-57-30
Screenshot from 2024-12-31 09-57-34

@Tschuppi81 Tschuppi81 merged commit 13baf03 into master Dec 31, 2024
14 checks passed
@Tschuppi81 Tschuppi81 deleted the feature/ogc-1936-web-statistics-add-link-for-users branch December 31, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants