Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build container images via jib-maven-plugin #301

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

hbruch
Copy link
Contributor

@hbruch hbruch commented Nov 10, 2024

Summary:

This PR adds jib-maven-plugin as build dependency which allows to build and publish onebusaway gtfs tools as docker images.

Note: currently, image names are build using their maven artifactId as repository names.
To build and publish them, an env variable CONTAINER_REGISTRY_NAMESPACE needs to be defined.

To build use e.g. CONTAINER_REGISTRY_NAMESPACE=mfdz mvn jib:dockerBuild, or, to build and publish to the registry CONTAINER_REGISTRY_NAMESPACE=mfdz mvn jib:build

It will build the following images (assuming current version is 4.0.1-SNAPSHOT):

mfdz/onebusaway-gtfs-merge-cli:4.0.1-SNAPSHOT
mfdz/onebusaway-gtfs-hibernate-cli:4.0.1-SNAPSHOT
mfdz/onebusaway-gtfs-transformer-cli:4.0.1-SNAPSHOT

According to jib-maven-plugin multi-module example, module-dependencies are built as reproducible builds.

@leonardehrenfried leonardehrenfried changed the title Build docker images via jib-maven-plugin Build container images via jib-maven-plugin Nov 10, 2024
@leonardehrenfried
Copy link
Collaborator

Thanks for this PR. I will merge this and tweak the settings a bit myself.

@leonardehrenfried leonardehrenfried merged commit 2147be1 into OneBusAway:master Nov 11, 2024
4 checks passed
@leonardehrenfried leonardehrenfried deleted the jib-maven-plugin branch November 11, 2024 08:39
@leonardehrenfried
Copy link
Collaborator

Sorry, I don't have the permissions to publish to Github Container Registry or Dockerhub. I will have to ask so it will take a little longer.

@leonardehrenfried
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants