Flex spec upgrade (separate location_id and group_id) #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
During the specification process of GTFS Flex the group decided that we don't want to put location and location group ids into the the column
stop_id
anymore. Instead new columnslocation_id
andlocation_group_id
instead.This makes the column
stop_id
optional.I've also introduced a new method
StopTime#getStopLocation
that returns the correct entity (stop, location, location group).cc @gcamp @westontrillium @tzujenchanmbd @eliasmbd