Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enhanced Code Block Interaction, Copy Button and Copied Icon Display on Hover #91

Closed

Conversation

ankitkumar748846
Copy link
Contributor

Description: Implemented a language to a code block. When you hover over the code block, a copy button appears. After clicking the copy button, a copied icon is displayed.

Issue fixed: #89

Changes done:

  • Task 1

Screenshots/Videos

Copy.mp4

✅️ By submitting this PR, I have verified the following

  • Checked to see if a similar PR has already been opened 🤔️
  • Reviewed the contributing guidelines 🔍️
  • Tried squashing the commits into one

Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the assignment of the heading variable, It looks like hljs is consistently getting shell script commands' language wrong. I think this is probably more trouble than it's worth for now, so please back this out. Everything else looks great.

@aaronbrethorst
Copy link
Member

I'm going to close this PR. Feel free to reopen once the issue noted above has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Enhancement to the Copy button.
2 participants