Allow an HttpClientFactory to be assigned to OpenAIAPI #103
+87
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to enable consumers to use
IHttpClientFactory
and apply resiliency best practices described in this document without a breaking change. Consumers can now implement non-functional requirements such as:Implementation wise, I opted not to modify the constructor as it takes an optional parameter. Adding another optional parameter is a breaking change, and mixing optional parameters with overloaded constructors is not generally recommended. Effectively seeking to minimize change.
Package wise, the dependency on
Microsoft.Extensions.Http
is no longer private.I used
Moq
in the unit tests to mock an HTTP Client and ensure the right client is used in the right place.Related issues that could be addressed with this change (or at least allow a workaround):
#102
#100
#91
#41
#28