Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding navbar all pages #40

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

msv6264
Copy link
Contributor

@msv6264 msv6264 commented Jan 4, 2025

Related Issue

Fixes #28

Description

[Please include a brief description of the changes or features added]

Type of PR

  • [✅] Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Screenshot 2025-01-04 225111
added similar navbar for all pages except register one since it is different page.

Checklist:

  • [✅] I have performed a self-review of my code
  • [✅ ] I have read and followed the Contribution Guidelines.
  • [ ✅] I have tested the changes thoroughly before submitting this pull request.
  • [✅ ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [✅ ] I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jan 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
scd-profile-score ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 6, 2025 7:39pm

Copy link

github-actions bot commented Jan 4, 2025

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTE.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Ojas-Arora
Copy link
Owner

@msv6264 Add the same Navabr in the Resume Page as well.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 4, 2025

Ok

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 5, 2025

@Ojas-Arora I have added navbar for resume page, can you please check.

Copy link
Owner

@Ojas-Arora Ojas-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msv6264 Update branch

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 5, 2025

Hello @Ojas-Arora I noticed that the branch is up-to-date, but I see a "1 change requested" notification. I’ve reviewed the changes, and they appear to be the same as the ones I made. Could you please clarify what has been changed or specify what I should do?

@SUGAM-ARORA
Copy link
Collaborator

Hello @Ojas-Arora I noticed that the branch is up-to-date, but I see a "1 change requested" notification. I’ve reviewed the changes, and they appear to be the same as the ones I made. Could you please clarify what has been changed or specify what I should do?

Check branchupdate.md for steps

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 6, 2025

I have updated the branch and it is upto date, can you please check now

@Ojas-Arora
Copy link
Owner

I have updated the branch and it is upto date, can you please check now

Not able to see the deployment as no new changes for branch update has been made

Copy link
Contributor Author

@msv6264 msv6264 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got some changes again I updated but can you tell me if you have requested any changes, I am getting like this
Screenshot 2025-01-07 011217

@Ojas-Arora
Copy link
Owner

@msv6264 That's no issue it's just showing about the changes that I have requested I will correct it. Will check the Deployment and will tell so.

Copy link
Owner

@Ojas-Arora Ojas-Arora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

@Ojas-Arora Ojas-Arora merged commit 1aeb3da into Ojas-Arora:main Jan 6, 2025
2 checks passed
@Ojas-Arora
Copy link
Owner

@msv6264 Have u Registered yourself on OS Leaderboard? I have to assign Points to u butt not able to do so.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 7, 2025

@Ojas-Arora Yeah, I have registered, I am also not able to see my name on leaderboard

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 7, 2025

@Ojas-Arora I will check and come back to you

@Ojas-Arora
Copy link
Owner

@msv6264 Ok whenver done Just tell me I will add your Points.

@msv6264
Copy link
Contributor Author

msv6264 commented Jan 8, 2025

Hello @Ojas-Arora my issue is resolved, please add the points

@Ojas-Arora Ojas-Arora added the done label Jan 8, 2025
@msv6264 msv6264 deleted the adding-navbar-all-pages branch January 10, 2025 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Same Navbar
3 participants