eventPassCardFooter: add next intl provider for EventPassContractReve… #271

AlexandreG-tech · 2024-02-08T08:11:13Z

User description

…alContractButton and mock next/cache for test in updateEventPassCart

EventPasses.tsx and PasCardSelect.tsx : added NextIntlProvider

migration: change order_amount_handling to not count quantity on update

payment-admin: integration tests to make sure stripeCheckoutSession is deleted if the execution of the function goes right

updateEventPassCart: change migration to not count existing pendingOrder quantity in total quantity and added tests for those edge cases

cart/purchase : reason in search params

stripe process: add button and action to cancel a purchase order and a stripe session, added tests for the getStripeActiveCheckoutSession function and especially the no user/user mail case

lowercase for all eth addresses : update tests and add migration for the insert trigger ; make the cancel my purchase button reactive

Type

Enhancement

Changes walkthrough

Relevant files

Enhancement

17 files

nftActivity.integration.test.ts `Update fromAddress and toAddress to use lowercase addresses in nftActivity.integration.test.ts` libs/indexer/alchemy/webhooks/src/lib/nftActivity.integration.test.ts Updated the `fromAddress` and `toAddress` values in the `mockActivity` and `mockActivity2` objects to use lowercase addresses.
packCollection.integration.test.ts `Update contractAddress to use lowercase addresses in packCollection.integration.test.ts` libs/nft/thirdweb-organizer/src/packCollection.integration.test.ts Updated the `contractAddress` values in the `mockActivity` and `mockActivity2` objects to use lowercase addresses.
pendingOrder.spec.ts `Add eventPass3 and test case for updating order with new quantity in pendingOrder.spec.ts` libs/gql/user/api/src/queries/cart/pendingOrder.spec.ts Added `eventPass3` object with a lowercase `contractAddress` value. Added a test case to check the update of an order with a new quantity that exceeds the max limit.
payment-admin.integration.test.ts `Add integration tests for confirmedStripeCheckoutSession in payment-admin.integration.test.ts` libs/payment/admin/src/lib/payment-admin.integration.test.ts Added integration tests for the `confirmedStripeCheckoutSession` function.
BoundedNumericStepper.tsx `Refactor BoundedNumericStepper to use value prop and onChange callback in BoundedNumericStepper.tsx` libs/ui/components/src/lib/bounded-numeric-stepper/BoundedNumericStepper.tsx Removed the `useState` hook and replaced it with a `value` prop and `onChange` callback. Updated the `increment` and `decrement` functions to use the `value` prop and `onChange` callback.
UserCart.tsx Add `reason` prop and section to `UserCart` in `UserCart.tsx` libs/features/cart/src/lib/UserCart/UserCart.tsx Added a new prop `reason` to `UserCartProps` and `UserCart` component. Added a new section in `UserCart` to display an alert if `reason` prop is provided.
PassCardSelect.tsx Add `value` prop to `PassCardSelect` in `PassCardSelect.tsx` libs/features/organizer/event/src/lib/molecules/PassCard/PassCardSelect.tsx Added a new prop `value` to `PassCardSelectProps` and `PassCardSelectContent` component. Updated the `PassCardSelectContent` component to use the `value` prop.
PassPurchaseHeader.tsx `Add CancelPurchaseButton component to PassPurchaseHeader in PassPurchaseHeader.tsx` libs/features/organizer/event/src/lib/molecules/PassPurchaseHeader/PassPurchaseHeader.tsx Added a new component `CancelPurchaseButton` to handle canceling a purchase order. Updated the `PurchaseInProgressAlert` component to include the `CancelPurchaseButton`.
CancelPurchaseButtonClient.tsx `Add CancelPurchaseButton component to handle canceling a purchase order in CancelPurchaseButtonClient.tsx` libs/features/organizer/event/src/lib/molecules/PassPurchaseHeader/CancelPurchaseButtonClient.tsx Added a new component `CancelPurchaseButton` to handle canceling a purchase order.
CartCancelled.stories.tsx `Add story for CartCancelled component with cancel purchase button in CartCancelled.stories.tsx` libs/features/cart/src/lib/CartCancelled/CartCancelled.stories.tsx Added a new story for `CartCancelled` component with cancel purchase button.
action.ts `Add cancelPurchaseForUser function to handle canceling a purchase order in action.ts` libs/features/organizer/event/src/lib/molecules/PassPurchaseHeader/action.ts Added a new function `cancelPurchaseForUser` to handle canceling a purchase order.
getStripeActiveCheckoutSession.ts `Update getStripeActiveCheckoutSession to throw error if user has no email in getStripeActiveCheckoutSession.ts` libs/features/payment-api/src/lib/getStripeActiveCheckoutSession.ts Updated the `getStripeActiveCheckoutSession` function to throw an error if the user has no email.
updateEventPassCart.ts `Update updateEventPassCart to revalidate tags in updateEventPassCart.ts` libs/features/organizer/event-actions/src/lib/updateEventPassCart.ts Updated the `updateEventPassCart` function to revalidate tags even when running in Jest.
PassPurchase.stories.tsx `Update WithPurchaseInProcess story to include cancel purchase button in PassPurchase.stories.tsx` libs/features/organizer/event/src/lib/pages/PassPurchase/PassPurchase.stories.tsx Updated the `WithPurchaseInProcess` story to include the cancel purchase button.
EventPassNftFilesTableClient.tsx `Return null if data array is empty in EventPassNftFilesTableClient.tsx` libs/features/back-office/events/src/lib/molecules/EventPassNftFilesTable/EventPassNftFilesTableClient.tsx Added a check to return `null` if the `data` array is empty.
EventPassCardFooter.tsx Replace `_locale` with `locale` in `EventPassCardFooter.tsx` libs/features/back-office/events/src/lib/molecules/EventPassCardFooter/EventPassCardFooter.tsx Removed the `_locale` variable and replaced it with `locale` variable.
getStripeActiveCheckoutSession.spec.ts `Add unit tests for getStripeActiveCheckoutSession in getStripeActiveCheckoutSession.spec.ts` libs/features/payment-api/src/lib/getStripeActiveCheckoutSession.spec.ts Added unit tests for the `getStripeActiveCheckoutSession` function.

✨ Usage guide:

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...

Enabling\disabling automation When you first install the app, the default mode for the describe tool is: `pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...]` meaning the `describe` tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: `pr_commands = ["/describe --pr_description.use_description_markers=true", ...]` the tool will replace every marker of the form `pr_agent:marker_name` in the PR description with the relevant content, where `marker_name` is one of the following: `type`: the PR type. `summary`: the PR summary. `walkthrough`: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.
Custom labels The default labels of the `describe` tool are quite generic: [`Bug fix`, `Tests`, `Enhancement`, `Documentation`, `Other`]. If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: `Main topic:performance` - pr_agent:The main topic of this PR is performance `New endpoint` - pr_agent:A new endpoint was added in this PR `SQL query` - pr_agent:A new SQL query was added in this PR `Dockerfile changes` - pr_agent:The PR contains changes in the Dockerfile ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.
Inline File Walkthrough 💎 For enhanced user experience, the `describe` tool can add file summaries directly to the "Files changed" tab in the PR page. This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs). To enable inline file summary, set `pr_description.inline_file_summary` in the configuration file, possible values are: `'table'`: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab. `true`: A collapsable file comment with changes title and a changes summary for each file in the PR. `false` (default): File changes walkthrough will be added only to the "Conversation" tab.
Utilizing extra instructions The `describe` tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: `[pr_description] extra_instructions=""" - The PR title should be in the format: '<PR type>: <title>' - The title should be short and concise (up to 10 words) - ... """` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

…alContractButton and mock next/cache for test in updateEventPassCart EventPasses.tsx and PasCardSelect.tsx : added NextIntlProvider migration: change order_amount_handling to not count quantity on update payment-admin: integration tests to make sure stripeCheckoutSession is deleted if the execution of the function goes right updateEventPassCart: change migration to not count existing pendingOrder quantity in total quantity and added tests for those edge cases cart/purchase : reason in search params stripe process: add button and action to cancel a purchase order and a stripe session, added tests for the getStripeActiveCheckoutSession function and especially the no user/user mail case lowercase for all eth addresses : update tests and add migration for the insert trigger ; make the cancel my purchase button reactive

vercel · 2024-02-08T08:11:19Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
back-office	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 9, 2024 3:05pm
marketplace	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 9, 2024 3:05pm

codiumai-pr-agent-free · 2024-02-08T08:13:30Z

PR Description updated to latest commit (f1b7855)

codiumai-pr-agent-free · 2024-02-08T08:14:05Z

PR Analysis

🎯 Main theme: This PR primarily focuses on enhancing the functionality of the application by introducing new features and making changes to existing ones. The changes include adding a new international provider for EventPassContractRevealContractButton, modifying the order_amount_handling migration, adding integration tests for stripeCheckoutSession, and updating the eventPassCart. It also includes changes to the stripe process, such as adding a button and action to cancel a purchase order and a stripe session.
📝 PR summary: The PR introduces several enhancements to the application, including changes to the order handling process, the addition of new tests, and the introduction of new features. The changes are spread across multiple files and include modifications to the handling of Ethereum addresses, the addition of a new international provider, and updates to the stripe process.
📌 Type of PR: Enhancement
🧪 Relevant tests added: Yes
⏱️ Estimated effort to review [1-5]: 4, because the PR includes changes to multiple files and introduces new functionality. The changes are also spread across different aspects of the application, including the handling of Ethereum addresses, the order handling process, and the stripe process.
🔒 Security concerns: No

PR Feedback

💡 General suggestions: The changes introduced in this PR seem to be well thought out and are likely to enhance the functionality of the application. However, it would be beneficial to ensure that all changes are thoroughly tested, especially those related to the handling of Ethereum addresses and the stripe process. Additionally, it would be helpful to include more detailed comments in the code to explain the purpose and functionality of the new features and changes.

✨ Usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.
When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:

/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...

With a configuration file, use the following template:

[pr_reviewer]
some_config1=...
some_config2=...

Utilizing extra instructions The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: `[pr_reviewer] # /review # extra_instructions=""" In the 'general suggestions' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.
How to enable\disable automation When you first install PR-Agent app, the default mode for the `review` tool is: `pr_commands = ["/review", ...]` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations
Auto-labels The `review` tool can auto-generate two specific types of labels for a PR: a `possible security issue` label, that detects possible security issues (`enable_review_labels_security` flag) a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag)
Extra sub-tools The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the possible options, and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more.
Auto-approve PRs By invoking: `/review auto_approve` The tool will automatically approve the PR, and add a comment with the approval. To ensure safety, the auto-approval feature is disabled by default. To enable auto-approval, you need to actively set in a pre-defined configuration file the following: `[pr_reviewer] enable_auto_approval = true` (this specific flag cannot be set with a command line argument, only in the configuration file, committed to the repository) You can also enable auto-approval only if the PR meets certain requirements, such as that the `estimated_review_effort` is equal or below a certain threshold, by adjusting the flag: `[pr_reviewer] maximal_review_effort = 5`
More PR-Agent commands To invoke the PR-Agent, add a comment using one of the following commands: /review: Request a review of your Pull Request. /describe: Update the PR title and description based on the contents of the PR. /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback. /ask <QUESTION>: Ask a question about the PR. /update_changelog: Update the changelog based on the PR's contents. /add_docs 💎: Generate docstring for new components introduced in the PR. /generate_labels 💎: Generate labels for the PR based on the PR's contents. /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. See the tools guide for more details. To list the possible configuration parameters, add a /config comment.

See the review usage page for a comprehensive guide on using this tool.

… the component doesn't render when there is no file

…e internal translations

hasura/app/migrations/default/1707365734019_insert_lowercase_trigger/up.sql

...tures/back-office/events/src/lib/molecules/EventPassFilesUploader/EventPassFilesUploader.tsx

libs/features/organizer/event/src/lib/commons/action.ts

sebpalluel · 2024-02-08T14:52:32Z

libs/features/organizer/event/src/lib/molecules/PassCard/PassCardSelectClient.tsx

+  const router = useRouter();
+  const [value, setValue] = useState(
+    boundedNumericStepperProps.initialValue || 0,
+  );
  const { toast } = useToast();
  const t = useTranslations('Organizer.Event.PassPurchase');

  return (
    <BoundedNumericStepper


Would be better to use a revalidateTag on the action (to avoid weird UX on the Sheet and intercepted route so pass purchase card version), instead of router.refresh, if nextjs is not buggy as it used to with this

Without the router.refresh on the first completion of the onChange function, it seems to switch to the /purchase instead of staying on the sheet .purchase, could be a revalidateTag causing a reload and eventually loading the /purchase because of the URL

…ts for the action

sebpalluel · 2024-02-09T14:39:11Z

...tures/back-office/events/src/lib/molecules/EventPassFilesUploader/EventPassFilesUploader.tsx

@@ -29,7 +29,7 @@ export interface EventPassFilesTableProps
  buttonClassName?: string;
 }

-export function EventPassFilesUploader(props: EventPassFilesTableProps) {
+export async function EventPassFilesUploader(props: EventPassFilesTableProps) {


Well no the issue here really is the 'use server'; at the top of the file that should be removed.

That way in the client context it's going to be a client component and on the server side a RSC. If it works ?

Oh no you are right, we are using getTranslations from server so never mind

sebpalluel · 2024-02-09T14:39:48Z

hasura/app/migrations/default/1707365734019_squashed/up.sql

@@ -1,3 +1,4 @@
+


We need to give a name after the unix timestamp that say shortly what's the migration about

sebpalluel · 2024-02-09T14:41:40Z

...tures/back-office/events/src/lib/molecules/EventPassFilesUploader/EventPassFilesUploader.tsx

@@ -29,7 +29,7 @@ export interface EventPassFilesTableProps
  buttonClassName?: string;
 }

-export function EventPassFilesUploader(props: EventPassFilesTableProps) {
+export async function EventPassFilesUploader(props: EventPassFilesTableProps) {


That way in the client context it's going to be a client component and on the server side a RSC. If it works ?

sebpalluel · 2024-02-09T14:42:19Z

...tures/back-office/events/src/lib/molecules/EventPassFilesUploader/EventPassFilesUploader.tsx

@@ -29,7 +29,7 @@ export interface EventPassFilesTableProps
  buttonClassName?: string;
 }

-export function EventPassFilesUploader(props: EventPassFilesTableProps) {
+export async function EventPassFilesUploader(props: EventPassFilesTableProps) {


Oh no you are right, we are using getTranslations from server so never mind

AlexandreG-tech temporarily deployed to preview February 8, 2024 08:11 — with GitHub Actions Inactive

codiumai-pr-agent-free bot added the enhancement New feature or request label Feb 8, 2024

codiumai-pr-agent-free bot added the Review effort [1-5]: 4 label Feb 8, 2024

passCardSelect.tsx : fix double localeMessages definition

652f64a

AlexandreG-tech temporarily deployed to preview February 8, 2024 08:20 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview – back-office February 8, 2024 08:25 Failure

vercel bot had a problem deploying to Preview – marketplace February 8, 2024 08:27 Failure

passCardSelect.tsx : fix double localeMessages definition

20e6013

AlexandreG-tech temporarily deployed to preview February 8, 2024 08:29 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview – back-office February 8, 2024 08:31 Failure

vercel bot had a problem deploying to Preview – marketplace February 8, 2024 08:32 Failure

AlexandreG-tech added 2 commits February 8, 2024 11:28

EventPassNftFilesTable.stories : delete story regarding no file since…

11e7e1b

… the component doesn't render when there is no file

add spec.ts to swcrc

3839cf7

AlexandreG-tech temporarily deployed to preview February 8, 2024 10:29 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview – back-office February 8, 2024 10:31 Failure

vercel bot had a problem deploying to Preview – marketplace February 8, 2024 10:32 Failure

add spec.ts to swcrc

c8116eb

AlexandreG-tech temporarily deployed to preview February 8, 2024 10:34 — with GitHub Actions Inactive

vercel bot deployed to Preview – back-office February 8, 2024 10:43 View deployment

vercel bot had a problem deploying to Preview – marketplace February 8, 2024 10:49 Failure

fix build error for features organizer event

e2d661f

AlexandreG-tech temporarily deployed to preview February 8, 2024 11:04 — with GitHub Actions Inactive

vercel bot deployed to Preview – back-office February 8, 2024 11:10 View deployment

vercel bot deployed to Preview – marketplace February 8, 2024 11:22 View deployment

fix build error for web and improve cancelPurchaseButtonClient to hav…

8ae6a10

…e internal translations

AlexandreG-tech temporarily deployed to preview February 8, 2024 11:36 — with GitHub Actions Inactive

vercel bot deployed to Preview – back-office February 8, 2024 11:42 View deployment

vercel bot deployed to Preview – marketplace February 8, 2024 11:52 View deployment

fix end to end for web and especially cartCancelled nextintlprovider

5591a4b

AlexandreG-tech temporarily deployed to preview February 8, 2024 13:28 — with GitHub Actions Inactive

vercel bot deployed to Preview – back-office February 8, 2024 13:34 View deployment

vercel bot deployed to Preview – marketplace February 8, 2024 13:42 View deployment

sebpalluel requested changes Feb 8, 2024

View reviewed changes

add tests and change migration to fix currentOwnerAddress and add tes…

09aed9e

…ts for the action

AlexandreG-tech temporarily deployed to preview February 8, 2024 22:14 — with GitHub Actions Inactive

vercel bot had a problem deploying to Preview – back-office February 8, 2024 22:17 Failure

vercel bot deployed to Preview – marketplace February 8, 2024 22:25 View deployment

squash migrations and fix build error

fdf0992

AlexandreG-tech temporarily deployed to preview February 9, 2024 12:06 — with GitHub Actions Inactive

vercel bot deployed to Preview – back-office February 9, 2024 12:12 View deployment

vercel bot deployed to Preview – marketplace February 9, 2024 12:19 View deployment

sebpalluel requested changes Feb 9, 2024

View reviewed changes

squash migrations name fix

e81c810

AlexandreG-tech temporarily deployed to preview February 9, 2024 14:52 — with GitHub Actions Inactive

vercel bot deployed to Preview – back-office February 9, 2024 14:58 View deployment

vercel bot deployed to Preview – marketplace February 9, 2024 15:05 View deployment

sebpalluel approved these changes Feb 9, 2024

View reviewed changes

sebpalluel had a problem deploying to preview February 9, 2024 15:23 — with GitHub Actions Failure

sebpalluel merged commit 44b4999 into staging Feb 9, 2024
16 of 17 checks passed

sebpalluel deleted the 267-26012024-bug-report branch February 9, 2024 15:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eventPassCardFooter: add next intl provider for EventPassContractReve… #271

eventPassCardFooter: add next intl provider for EventPassContractReve… #271

AlexandreG-tech commented Feb 8, 2024 •

edited by codiumai-pr-agent-free bot

Loading

vercel bot commented Feb 8, 2024 •

edited

Loading

codiumai-pr-agent-free bot commented Feb 8, 2024

codiumai-pr-agent-free bot commented Feb 8, 2024

sebpalluel Feb 8, 2024

AlexandreG-tech Feb 8, 2024

sebpalluel Feb 9, 2024

sebpalluel Feb 9, 2024

sebpalluel Feb 9, 2024

sebpalluel Feb 9, 2024

sebpalluel Feb 9, 2024

sebpalluel Feb 9, 2024

eventPassCardFooter: add next intl provider for EventPassContractReve… #271

eventPassCardFooter: add next intl provider for EventPassContractReve… #271

Conversation

AlexandreG-tech commented Feb 8, 2024 • edited by codiumai-pr-agent-free bot Loading

User description

Type

Changes walkthrough

vercel bot commented Feb 8, 2024 • edited Loading

codiumai-pr-agent-free bot commented Feb 8, 2024

codiumai-pr-agent-free bot commented Feb 8, 2024

PR Analysis

PR Feedback

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlexandreG-tech commented Feb 8, 2024 •

edited by codiumai-pr-agent-free bot

Loading

vercel bot commented Feb 8, 2024 •

edited

Loading